Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set required and aria on input when input is required #606

Closed
wants to merge 0 commits into from
Closed

Set required and aria on input when input is required #606

wants to merge 0 commits into from

Conversation

CharlieWinkwaves
Copy link
Contributor

fixes #604

@CharlieWinkwaves CharlieWinkwaves mentioned this pull request Oct 27, 2021
Merged
@lcreid lcreid requested a review from thimo October 28, 2021 02:02
lcreid
lcreid reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious about the missing space in check boxes.

test/bootstrap_form_test.rb Outdated
<label class="form-check-label" for="user_misc_1"> Foo</label>
<label class="form-check-label" for="user_misc_1">Foo</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has that space disappeared? Maybe I didn't notice this in the PR against main , and if so, sorry. But I'm curious why it's gone?

Copy link
Contributor Author

@CharlieWinkwaves CharlieWinkwaves Oct 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure that my test failed with the space, but i double checked just know and with or without the space before Foo it succeeds.
Both in my branches as in the main branch.
So I think the space was absolute before already but why the test succeeded before i do not know.
When looking in the browser at a checkbox, the label does not have a space either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need to change the cases where there's a space before the text, I'd prefer not to change it. The fewer changes, the less likely we inadvertently cause problems for someone who uses bootstrap_form. Can you make the change back to the way it was, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem fixed it what do you want me to do with the commit already merged to master?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just write up an issue describing how Bootstrap 4 tests are different from Bootstrap 5, we can review it later. But if it's more work to do write up an issue than to do another PR for main, then submit another PR. Does that make sense?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is resolved, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is resolved

@CharlieWinkwaves CharlieWinkwaves force-pushed the bootstrap-5-required-fields branch 2 times, most recently from 9564f23 to d32c9fb Compare November 1, 2021 11:17
lcreid
lcreid approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR! Great work!

@donv
Copy link
Collaborator

donv commented Dec 28, 2021

This looks like a good change. Any reason not to merge it?

@CharlieWinkwaves could you rebase onto master?

@CharlieWinkwaves CharlieWinkwaves changed the base branch from bootstrap-5 to main December 28, 2021 15:36
@CharlieWinkwaves
Copy link
Contributor Author

I do not know why but is keeps saying that this PR has 4 commits in it

@CharlieWinkwaves CharlieWinkwaves force-pushed the bootstrap-5-required-fields branch 4 times, most recently from 4d3e178 to 131fc0b Compare December 29, 2021 09:28
@CharlieWinkwaves
Copy link
Contributor Author

@lcreid @donv We have pulled the latest v5 and we noticed that these changes are overwritten by a merge commit. And are thus not in the latest version

@CharlieWinkwaves CharlieWinkwaves mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcreid lcreid lcreid approved these changes

@donv donv donv approved these changes

@thimo thimo Awaiting requested review from thimo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If an input is required then the input does nog always get the required element
3 participants
@CharlieWinkwaves @donv @lcreid