Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the wrapper class #618

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Allow overriding the wrapper class #618

merged 2 commits into from
Jan 9, 2022

Conversation

donv
Copy link
Collaborator

@donv donv commented Dec 28, 2021

The wrapper now has a mb-3 class by default which is correct by the Bootstrap 5 migration guide and documentation. 馃憤

However, when you want to remove the bottom margin like some of the tests do, there should be a way to omit the mb-3 class. I think wrapper_class: false should do this, so I'll add it to this PR.

Then, when you add classes, you should be able to add them to a clean slate. That means that you need to include the mb-3 class if you want it.

What do you think?

@donv donv requested a review from thimo December 28, 2021 13:19
@donv donv self-assigned this Dec 28, 2021
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I agree that we should have some way of overriding the default behaviour. Take a look at my comment and let me know what you think.

README.md Show resolved Hide resolved
@donv donv merged commit 17f6522 into main Jan 9, 2022
@donv donv deleted the override_wrapper_class branch January 9, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants