Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sort-changed not working with vue3 #1798

Closed
6 tasks done
amjadkhalil33 opened this issue Feb 25, 2024 · 3 comments
Closed
6 tasks done

@sort-changed not working with vue3 #1798

amjadkhalil33 opened this issue Feb 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@amjadkhalil33
Copy link

Describe the bug

B-table @sort-changed not working with vue3

Reproduction

/

Used Package Manager

pnpm

Validations

  • Have tested with the latest version. This is still alpha version and sometime things change rapidly.
  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@amjadkhalil33 amjadkhalil33 added the bug Something isn't working label Feb 25, 2024
@waiyanmintun
Copy link

not a bug but method name changed to @sorted(sortBy string, isDesc boolean)

but :sort-by :sort-desc outlined doesn't work

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity. It will not be auto-closed

@github-actions github-actions bot added the stale There has been no additional replies or questions and the thread is assumed closed label Mar 31, 2024
@VividLemon VividLemon self-assigned this Mar 31, 2024
@github-actions github-actions bot removed the stale There has been no additional replies or questions and the thread is assumed closed label Apr 1, 2024
@VividLemon
Copy link
Member

It appears this #1798 (comment) is the correct behavior. With the change to sortBy becoming a v-modelable value, one could use that to determine when sort has changed (@update:sort-by). Alternatively, the sorted event emits which value has changed in the sortby. Although one could do the same by checking the diff of the model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants