chore: remove Booleanish type and useBooleanish composable #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
VividLemon
requested changes
Feb 22, 2024
packages/bootstrap-vue-next/src/components/BAccordion/BAccordion.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormGroup/BFormGroup.vue
Outdated
Show resolved
Hide resolved
|
@VividLemon thank you for your thorough review. |
VividLemon
reviewed
Feb 23, 2024
packages/bootstrap-vue-next/src/components/BFormGroup/BFormGroup.vue
Outdated
Show resolved
Hide resolved
VividLemon
reviewed
Feb 23, 2024
packages/bootstrap-vue-next/src/components/BFormInput/BFormInput.vue
Outdated
Show resolved
Hide resolved
VividLemon
requested changes
Feb 23, 2024
packages/bootstrap-vue-next/src/components/BFormSelect/BFormSelect.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormSelect/BFormSelect.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormSpinbutton/BFormSpinbutton.vue
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormTags/BFormTags.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BFormTextarea/BFormTextarea.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/components/BOffcanvas/BOffcanvas.vue
Outdated
Show resolved
Hide resolved
packages/bootstrap-vue-next/src/composables/useRadiusElementClasses.ts
Outdated
Show resolved
Hide resolved
BREAKING CHANGE: remove Booleanish type and useBooleanish composable, replace by plain boolean type Closes: bootstrap-vue-next#1774
3 tasks
VividLemon
requested review from
VividLemon
and removed request for
VividLemon
VividLemon
reviewed
Feb 28, 2024
packages/bootstrap-vue-next/src/components/BFormFile/BFormFile.vue
Outdated
Show resolved
Hide resolved
VividLemon
requested changes
Feb 28, 2024
packages/bootstrap-vue-next/src/components/BFormGroup/BFormGroup.vue
Outdated
Show resolved
Hide resolved
VividLemon
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Small replication
n/a
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedBEGIN_COMMIT_OVERRIDE
feat!: remove Booleanish type and useBooleanish composable, replace plain boolean type fixes #1774
END_COMMIT_OVERRIDE