feat(utils): inject getId to allow for custom id generation #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VividLemon
requested changes
Apr 3, 2024
6 tasks
|
Tested with nuxt kitchensink (all the playground components) and most of the hydration mismatches are gone :) |
VividLemon
requested changes
Apr 4, 2024
VividLemon
approved these changes
Apr 14, 2024
Merged
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Apr 16, 2024
* upstream/main: ci: add workflow dispatch to docs deploy chore: release main fix(BFormCheckbox): Prevent empty string being cast to true fixes bootstrap-vue-next#1822 feat(utils): inject getId to allow for custom id generation (bootstrap-vue-next#1836) BTable multisort (bootstrap-vue-next#1842) fix(BFormSelect): array of numbers or dates (bootstrap-vue-next#1839) fix(BPopover and Btooltip): Fixes bootstrap-vue-next#1232 - do not create a new app fro each tooltip or popover (bootstrap-vue-next#1837) fix(BFormFile): add properties placement and browser as in BootstrapVue (bootstrap-vue-next#1797) feat(BCheckbox)!: Implement reverse and without label (bootstrap-vue-next#1825) docs: Add documentation and parity section to contributing.md (bootstrap-vue-next#1834) vscode vue typescript plugin is now depricated and included in volar
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Apr 17, 2024
* upstream/main: update vue deps (bootstrap-vue-next#1850) fix(BPopover): fix injection out of setup context. (bootstrap-vue-next#1848) ci: add workflow dispatch to docs deploy chore: release main fix(BFormCheckbox): Prevent empty string being cast to true fixes bootstrap-vue-next#1822 feat(utils): inject getId to allow for custom id generation (bootstrap-vue-next#1836) BTable multisort (bootstrap-vue-next#1842) fix(BFormSelect): array of numbers or dates (bootstrap-vue-next#1839) fix(BPopover and Btooltip): Fixes bootstrap-vue-next#1232 - do not create a new app fro each tooltip or popover (bootstrap-vue-next#1837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Warning
Once Vue 3.5 is released, this PR will (likely) become obsolete in favour of the official method for generating IDs. If it is acceptable to wait for the 3.5 release, please close this PR.
Closes: #1730
This PR allows users to provide their own implementation for generating IDs. For example in Nuxt >= 3.10, to use SSR-friendly IDs.
Note
The Nuxt implementation above doesn't work for components with
inheritAttrs: falsedue to the implementation of Nuxt'suseId. For example,BFormRadio.Credits: tailwindlabs/headlessui#2959 radix-vue/radix-vue#718
Small replication
Issue is described in #1730
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied