fix(BForm*): Workaround for sfc type inference issues in BFormRadio*and BFormChecbox* #1856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Based on vuejs/core#10726 these changes should fix #1846 and #1854, but they don't (again, assuming I understand how the system works).
I'm still getting the same warnings
Invalid prop: type check failed for prop "modelValue". Expected Boolean | String, got Object at <BFormRadioGroup...
andInvalid prop: type check failed for prop "modelValue". Expected String | Boolean, got Array at <BFormCheckbox
.I made these changes locally and did a
pnpm install
which built thepackages/bootstrap-vue-next
directory (among other things), which updatedpackage/bootstrap-vue-next/dist/bootstrap-vue-next.mjs
. I believe this is the file that the browser is actually loading to execute the BSVN code when I'm running the playground.Based on the investigation that @xvaara and @VividLemon did cited in the vusjs/core bug above, I would expect the generated javascript to have model definitions that reflect the typescript, but here's what I'm seeing.
I also tried defining the types in an external file in the vue.js playground and things still worked, so that doesn't appear to be the difference.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
feat(...)
fix(...)
docs(...)
The PR fulfills these requirements:
CHANGELOG
is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied