Skip to content

Commit

Permalink
fix(modal): Modal jumps when dialog height changes (#1182)
Browse files Browse the repository at this point in the history
Building on #1058...  If the modal dialog's content height
changed (e.g., "v-if" conditionally displayed an error message),
the `padding-right` could be applied inconsistently.

twbs/bootstrap#23672 fixed this by calling `this.adjustDialog()`
during `onBeforeEnter()`, as well
  • Loading branch information
DabeDotCom authored and tmorehouse committed Oct 9, 2017
1 parent b11ca85 commit 126fe95
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/components/modal.vue
Expand Up @@ -387,6 +387,7 @@
this.is_transitioning = true;
this.checkScrollbar();
this.setScrollbar();
this.adjustDialog();
addClass(document.body, 'modal-open');
this.setResizeEvent(true);
},
Expand Down

0 comments on commit 126fe95

Please sign in to comment.