Skip to content

Commit

Permalink
[tabs] minor fix (#475)
Browse files Browse the repository at this point in the history
* [carousel] Fixed this arg in forEach

Should address issue #396

* [carousel] coerce querySelectorAll into an array

Coerce slide nodelist into an Array

* [carousel] ESLint

* [input-group-addon] conditional ID on root element

* [nav-item-dropdown] add ID to root element

* [popover] [tooltip

* Delete popover.js

* [tabs] Minor fix

Rely on testing tab.localActive (current state) rather than tab.active (initial state)
  • Loading branch information
tmorehouse authored and pi0 committed May 29, 2017
1 parent 7bcdb5d commit 522bccb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/components/tabs.vue
Expand Up @@ -185,7 +185,7 @@
// Deactivate any previous active tab(s)
this.tabs.forEach( t => {
if (t !== tab && t.active) {
if (t !== tab && t.localActive) {
this.$set(t, 'localActive', false);
}
});
Expand Down

0 comments on commit 522bccb

Please sign in to comment.