Merge c7dfd56 into 05b8ffd

bootstrap-vue · Feb 2, 2021 · 73f9627 · 73f9627
2 parents 05b8ffd + c7dfd56
commit 73f9627
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/src/components/form-group/form-group.js b/src/components/form-group/form-group.js
@@ -305,7 +305,6 @@ export const BFormGroup = {
           props: {
             ariaLive: feedbackAriaLive,
             id: invalidFeedbackId,
-            role: feedbackAriaLive ? 'alert' : null,
             // If state is explicitly `false`, always show the feedback
             state,
             tooltip
@@ -326,7 +325,6 @@ export const BFormGroup = {
           props: {
             ariaLive: feedbackAriaLive,
             id: validFeedbackId,
-            role: feedbackAriaLive ? 'alert' : null,
             // If state is explicitly `true`, always show the feedback
             state,
             tooltip

diff --git a/src/components/form-group/form-group.spec.js b/src/components/form-group/form-group.spec.js
@@ -321,14 +321,12 @@ describe('form-group', () => {
     const $invalidFeedback = wrapper.find('.invalid-feedback')
     expect($invalidFeedback.exists()).toBe(true)
     expect($invalidFeedback.text()).toEqual('bar')
-    expect($invalidFeedback.attributes('role')).toEqual('alert')
     expect($invalidFeedback.attributes('aria-live')).toEqual('assertive')
     expect($invalidFeedback.attributes('aria-atomic')).toEqual('true')
 
     const $validFeedback = wrapper.find('.valid-feedback')
     expect($validFeedback.exists()).toBe(true)
     expect($validFeedback.text()).toEqual('baz')
-    expect($validFeedback.attributes('role')).toEqual('alert')
     expect($validFeedback.attributes('aria-live')).toEqual('assertive')
     expect($validFeedback.attributes('aria-atomic')).toEqual('true')
 
@@ -373,14 +371,12 @@ describe('form-group', () => {
     let $invalidFeedback = wrapper.find('.invalid-feedback')
     expect($invalidFeedback.exists()).toBe(true)
     expect($invalidFeedback.text()).toEqual('bar')
-    expect($invalidFeedback.attributes('role')).toEqual('alert')
     expect($invalidFeedback.attributes('aria-live')).toEqual('polite')
     expect($invalidFeedback.attributes('aria-atomic')).toEqual('true')
 
     let $validFeedback = wrapper.find('.valid-feedback')
     expect($validFeedback.exists()).toBe(true)
     expect($validFeedback.text()).toEqual('baz')
-    expect($validFeedback.attributes('role')).toEqual('alert')
     expect($validFeedback.attributes('aria-live')).toEqual('polite')
     expect($validFeedback.attributes('aria-atomic')).toEqual('true')