Skip to content

Commit

Permalink
Don't use hrefString fallback. fixes #331
Browse files Browse the repository at this point in the history
router-link currently adds proper href on server side and this hack is not needed anymore.
Also this prevent unwanted behaviours like #331
  • Loading branch information
Pooya Parsa committed May 3, 2017
1 parent 81c65c7 commit dd9425b
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions lib/components/link.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:disabled="disabled"
:aria-disabled="disabled ? 'true' : 'false'"
:to="to"
:href="hrefString"
:href="href"
:exact="exact"
@click="click"
>
Expand All @@ -17,12 +17,6 @@
computed: {
componentType() {
return (this.$router && this.to) ? 'router-link' : 'a';
},
hrefString() {
if (this.to) {
return this.to.path || this.to;
}
return this.href;
}
},
props: {
Expand Down

0 comments on commit dd9425b

Please sign in to comment.