Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): Add dropright and dropleft direction support #2117

Merged

Conversation

jacobmllr95
Copy link
Member

This commit adds support for dropright and dropleft directions for the dropdown component.

Closes #2108.

This commit adds support for the dropright` and `dropleft` directions for the dropdown component.

Closes bootstrap-vue#2108.
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #2117 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2117      +/-   ##
==========================================
+ Coverage   64.71%   64.75%   +0.03%     
==========================================
  Files         156      156              
  Lines        2945     2948       +3     
  Branches      807      810       +3     
==========================================
+ Hits         1906     1909       +3     
  Misses        752      752              
  Partials      287      287
Impacted Files Coverage Δ
src/mixins/dropdown.js 7.14% <ø> (ø) ⬆️
src/components/dropdown/dropdown.js 100% <100%> (ø) ⬆️
src/components/tooltip/index.js 100% <0%> (ø) ⬆️
src/components/popover/index.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39a855...f412c4f. Read the comment docs.

@tmorehouse tmorehouse merged commit e186639 into bootstrap-vue:dev Oct 29, 2018
@tmorehouse
Copy link
Member

Thanks!

@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
@jacobmllr95 jacobmllr95 deleted the feat-dropdown-all-directions branch November 14, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants