fix(input-group): Minor fixes and documentation update #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`staticClass` assumes the classes applied to the element are "static" and never changing during a DOM patch. This should be be using `class` instead, as one could (theoretically) change the value of `.append` prop after render, which needs to change the class name rendered (a non static class)
this component should **not** expose an append prop (it is internal only)
this component should **not** expose an append prop (it is internal only)
Codecov Report
@@ Coverage Diff @@
## dev #2128 +/- ##
==========================================
+ Coverage 64.88% 64.97% +0.09%
==========================================
Files 156 158 +2
Lines 2950 2958 +8
Branches 810 811 +1
==========================================
+ Hits 1914 1922 +8
Misses 749 749
Partials 287 287
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
Some adjustments to the render functions of
b-input-groupand it's sub components. Addresses possibleundefinedcontent issues.Includes component reference for sub components, and removed unneeded props in the append/prepend sub-component.
Includes rendering Vue placeholder elements (
<!---->) for optional content areas, improving DOM patch performance.PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranchfixes #xxxx[,#xxxx], where "xxxx" is the issue number)If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:
PR titles should following the Conventional Commits naming convention