Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover/tooltip): Add boundaryPadding prop to override Popper.js default padding #2475

Merged

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

This PR add a new boundaryPadding property for <b-popover> and <b-tooltip> components to override Popper.js default padding to the boundariesElement of 5px.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #2475 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2475   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files         172      172           
  Lines        3240     3240           
  Branches      916      916           
=======================================
  Hits         2321     2321           
  Misses        667      667           
  Partials      252      252
Impacted Files Coverage Δ
src/utils/tooltip.class.js 100% <ø> (ø) ⬆️
src/mixins/toolpop.js 42.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9790dc2...28fe42f. Read the comment docs.

@tmorehouse
Copy link
Member

@jackmu95 could you maybe add a small blurb to the docs about the new prop?

@jacobmllr95
Copy link
Member Author

@jackmu95 could you maybe add a small blurb to the docs about the new prop?

Done.

@tmorehouse tmorehouse merged commit c8ad487 into bootstrap-vue:dev Feb 12, 2019
@jacobmllr95 jacobmllr95 deleted the feat-toolpop-boundary-padding-prop branch February 12, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants