-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): focus-out handling when new focus comes from another dropdown-toggle
(closes #4113)
#4139
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4139 +/- ##
==========================================
+ Coverage 99.86% 99.86% +<.01%
==========================================
Files 238 238
Lines 4471 4473 +2
Branches 1260 1261 +1
==========================================
+ Hits 4465 4467 +2
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Playground test markup: <div>
<b-navbar type="dark" variant="dark" toggleable>
<b-navbar-nav>
<b-nav-item href="#">Home</b-nav-item>
<!-- Navbar dropdowns -->
<b-nav-item-dropdown text="Lang" right id="lang-dd">
<b-dropdown-item href="#">EN</b-dropdown-item>
<b-dropdown-item href="#">ES</b-dropdown-item>
<b-dropdown-item href="#">RU</b-dropdown-item>
<b-dropdown-item href="#">FA</b-dropdown-item>
</b-nav-item-dropdown>
<b-nav-item-dropdown text="User" right id="user-dd">
<b-dropdown-item href="#">Account</b-dropdown-item>
<b-dropdown-item href="#">Settings</b-dropdown-item>
</b-nav-item-dropdown>
</b-navbar-nav>
</b-navbar>
</div> |
Hmmm... works better.. but back to the same issue with keyboard (TAB) navigation not closing the dropdown (if a dropdown toggle is next in the tab sequence) |
Describe the PR
This PR fixes the
<b-dropdown>
and<b-nav-item-dropdown>
(when vertical and inline menu is displayed) close handling when focus is lost by clicking an item below, and the item's click handler not firing due to the position of the item moving before the click handler gets a chance to be triggered.Uses a setTimeout delay to postpone the drop down menu collapse (when in a navbar) when the menu looses focus.
Closes #4113.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: