Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-tabs): add ability to provide custom tab button attributes (closes: #4803) #4806

Merged
merged 10 commits into from Feb 23, 2020
Merged

Conversation

andrewvasilchuk
Copy link
Contributor

@andrewvasilchuk andrewvasilchuk commented Feb 20, 2020

Describe the PR

I need somehow to assign custom attributes to the rendered button.

Closes: #4803

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Issue: #4803

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #4806 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4806      +/-   ##
==========================================
+ Coverage   99.93%   99.93%   +<.01%     
==========================================
  Files         263      263              
  Lines        5852     5853       +1     
  Branches     1526     1527       +1     
==========================================
+ Hits         5848     5849       +1     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/pagination/pagination.js 100% <ø> (ø) ⬆️
src/mixins/pagination.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f8db1...39d7f7d. Read the comment docs.

@tmorehouse tmorehouse added PR: Minor Requires minor version bump Type: Feature Status: Changes Needed Pull request needs changes and removed Status: Details Needed labels Feb 20, 2020
@tmorehouse tmorehouse added this to In progress in 2.6.0 via automation Feb 20, 2020
@tmorehouse tmorehouse removed the Status: Changes Needed Pull request needs changes label Feb 21, 2020
@tmorehouse tmorehouse changed the title feat(b-tabs): add ability to provide custom button attributes (fixes: #4803) feat(b-tabs): add ability to provide custom button attributes (closes: #4803) Feb 21, 2020
@tmorehouse tmorehouse changed the title feat(b-tabs): add ability to provide custom button attributes (closes: #4803) feat(b-tabs): add ability to provide custom tab button attributes (closes: #4803) Feb 23, 2020
@tmorehouse tmorehouse merged commit c541d3d into bootstrap-vue:dev Feb 23, 2020
2.6.0 automation moved this from In progress to Done Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Requires minor version bump Type: Feature
Projects
No open projects
2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

feat(b-tab): add ability to specify button attributes
3 participants