Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom components): avoid using padding/margin utility classes where possible (closes #5117) #5121

Merged
merged 42 commits into from
Apr 12, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 8, 2020

Describe the PR

Minor updates to custom component dom structure and styling, to remove hard-coded margin and padding utility classes

Closes #5117

  • b-calendar
  • b-form-datepicker
  • b-time
  • b-form-timepicker
  • b-form-spinbutton

Results in slightly increased custom SCSS, but also results in slightly reduced code size.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) SCSS / Structure

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #5121 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #5121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          277       277           
  Lines         6537      6537           
  Branches      1617      1617           
=========================================
  Hits          6537      6537           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb9a91...6fb9a91. Read the comment docs.

@tmorehouse tmorehouse changed the title chore(b-calendar, b-form-datepicker): minor updates to structure and styling chore(b-calendar, b-form-datepicker): minor updates to structure and styling (closes #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title chore(b-calendar, b-form-datepicker): minor updates to structure and styling (closes #5117) chore(b-calendar, b-form-datepicker): minor updates to structure and styling (addresses #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title chore(b-calendar, b-form-datepicker): minor updates to structure and styling (addresses #5117) chore(calendar, datepicker, time, timepicker): minor updates to structure and styling (addresses #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title chore(calendar, datepicker, time, timepicker): minor updates to structure and styling (addresses #5117) chore(calendar, datepicker, time, timepicker, spinbutton): minor updates to structure and styling (addresses #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title chore(calendar, datepicker, time, timepicker, spinbutton): minor updates to structure and styling (addresses #5117) feat(calendar, datepicker, time, timepicker, spinbutton): avoid using padding/margin utility classes (closes #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title feat(calendar, datepicker, time, timepicker, spinbutton): avoid using padding/margin utility classes (closes #5117) feat(custom components): avoid using padding/margin utility classes (closes #5117) Apr 8, 2020
@tmorehouse tmorehouse changed the title feat(custom components): avoid using padding/margin utility classes (closes #5117) feat(custom components): avoid using padding/margin utility classes where possible (closes #5117) Apr 8, 2020
@tmorehouse tmorehouse marked this pull request as ready for review April 8, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap Customization breaks component UI
2 participants