-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom components): avoid using padding/margin utility classes where possible (closes #5117) #5121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorehouse
added
Status: WIP
Type: Refactor
PR: Patch
Requires patch version bump
Type: SCSS
labels
Apr 8, 2020
Codecov Report
@@ Coverage Diff @@
## dev #5121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 277 277
Lines 6537 6537
Branches 1617 1617
=========================================
Hits 6537 6537 Continue to review full report at Codecov.
|
tmorehouse
changed the title
chore(b-calendar, b-form-datepicker): minor updates to structure and styling
chore(b-calendar, b-form-datepicker): minor updates to structure and styling (closes #5117)
Apr 8, 2020
tmorehouse
changed the title
chore(b-calendar, b-form-datepicker): minor updates to structure and styling (closes #5117)
chore(b-calendar, b-form-datepicker): minor updates to structure and styling (addresses #5117)
Apr 8, 2020
tmorehouse
changed the title
chore(b-calendar, b-form-datepicker): minor updates to structure and styling (addresses #5117)
chore(calendar, datepicker, time, timepicker): minor updates to structure and styling (addresses #5117)
Apr 8, 2020
tmorehouse
changed the title
chore(calendar, datepicker, time, timepicker): minor updates to structure and styling (addresses #5117)
chore(calendar, datepicker, time, timepicker, spinbutton): minor updates to structure and styling (addresses #5117)
Apr 8, 2020
tmorehouse
changed the title
chore(calendar, datepicker, time, timepicker, spinbutton): minor updates to structure and styling (addresses #5117)
feat(calendar, datepicker, time, timepicker, spinbutton): avoid using padding/margin utility classes (closes #5117)
Apr 8, 2020
tmorehouse
changed the title
feat(calendar, datepicker, time, timepicker, spinbutton): avoid using padding/margin utility classes (closes #5117)
feat(custom components): avoid using padding/margin utility classes (closes #5117)
Apr 8, 2020
tmorehouse
changed the title
feat(custom components): avoid using padding/margin utility classes (closes #5117)
feat(custom components): avoid using padding/margin utility classes where possible (closes #5117)
Apr 8, 2020
jacobmllr95
approved these changes
Apr 11, 2020
Merged
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Minor updates to custom component dom structure and styling, to remove hard-coded margin and padding utility classes
Closes #5117
Results in slightly increased custom SCSS, but also results in slightly reduced code size.
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: