feat(navbar-brand): New component <b-navbar-brand> #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit component for `<b-navbar-brand>`
lib/components/navbar-brand.vue
Outdated
| </b-link> | ||
| <div v-else :is="tag" class="navbar-brand"> | ||
| <slot></slot> | ||
| </div> |
There was a problem hiding this comment.
Might be slightly more declarative just using the <component> tag here. Shows it off clearly as a dynamic tag.
There was a problem hiding this comment.
Yeah, was thinking that
| <b-link v-if="isLink" | ||
| class="navbar-brand" | ||
| v-bind="linkProps" | ||
| @click="$emit('click', $event)"> |
There was a problem hiding this comment.
Once we hit v2.4 as a peer dependency with Vue, we can start using v-bind="$attrs" v-on="$listeners" to proxy everything off to link or whatever. And that is glorious!
There was a problem hiding this comment.
Excellent. Will be nice when that happens
alexsasharegan
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New component for rendering navbar brand content.
Setting props
toorhrefwill render ab-link.If both
toandhrefare not present, then the navbar-brand will be resndered as adivby default (configurable via thetagprop)