feat(dropdowns): functional dropdown components and testing #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.x #848 +/- ##
==========================================
+ Coverage 40.27% 40.94% +0.67%
==========================================
Files 84 84
Lines 2364 2325 -39
Branches 667 658 -9
==========================================
Hits 952 952
+ Misses 1249 1222 -27
+ Partials 163 151 -12
Continue to review full report at Codecov.
|
|
Moving the code coverage needle |
|
That might actually be a |
tmorehouse
reviewed
Aug 15, 2017
lib/components/dropdown-header.js
Outdated
| props.tag, | ||
| mergeData(data, { | ||
| staticClass: "dropdown-header", | ||
| attrs: { tabindex: "-1" } |
There was a problem hiding this comment.
The main dropdown mixin doesn't focus headers any more. users will need to point aria-describedby attribute to a header with an ID.
There was a problem hiding this comment.
Should I remove this then?
tmorehouse
reviewed
Aug 15, 2017
| bDropdownItem, | ||
| bDropdownItem as bDdItem, |
tmorehouse
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.