feat(progress): Support for multiple progress bars #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
Codecov Report
@@ Coverage Diff @@
## 1.x #889 +/- ##
==========================================
+ Coverage 40.74% 40.79% +0.05%
==========================================
Files 88 89 +1
Lines 2236 2255 +19
Branches 644 653 +9
==========================================
+ Hits 911 920 +9
- Misses 1169 1179 +10
Partials 156 156
Continue to review full report at Codecov.
|
tmorehouse
commented
Aug 19, 2017
| .progress-bar { | ||
| transition: all .5s; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Bootstrap V4.beta CSS includes transition for-progress-bar, so this CSS is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multiple progress bars by introducing a new
b-progress-barsub component.sub component b-progress-bar will inherit many of the props from the parent b-progress component, but my be overridden at the sub component level.
PR includes updated docs and examples