perf(dom): Improve DOM utils code for minification & tree-shaking #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than polyfill, use native where available, and fallback to emulation function
Codecov Report
@@ Coverage Diff @@
## dev #1284 +/- ##
==========================================
- Coverage 42.44% 41.83% -0.62%
==========================================
Files 130 130
Lines 2721 2701 -20
Branches 858 858
==========================================
- Hits 1155 1130 -25
- Misses 1252 1255 +3
- Partials 314 316 +2
Continue to review full report at Codecov.
|
tmorehouse
changed the title
tmorehouse
changed the title
Since we do not support IE 8 (or 9 for that matter), we can use the faster polyfill that uses the 'Element..matches' function. But since Element.matches may be a prefixed function in some browsers, we use our own `matches` handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move polyfill functions into respective dom utility and avoid polyfilling native prototype