feat(alert): Add fade prop #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1785 +/- ##
==========================================
+ Coverage 61.02% 61.04% +0.01%
==========================================
Files 154 154
Lines 2861 2862 +1
Branches 790 791 +1
==========================================
+ Hits 1746 1747 +1
Misses 800 800
Partials 315 315
Continue to review full report at Codecov.
|
pi0
approved these changes
Apr 29, 2018
mosinve
reviewed
Apr 29, 2018
src/components/alert/alert.js
Outdated
| @@ -16,10 +18,15 @@ export default { | |||
| [ this.$slots.dismiss ] | |||
| ) | |||
| } | |||
| return h( | |||
| let alert = h( | |||
|
@pi0 Sure, let me know if this is ok. |
pi0
approved these changes
Apr 29, 2018
89 tasks
tmorehouse
reviewed
Nov 21, 2018
| } | ||
| .fade-enter, .fade-leave-to { | ||
| opacity: 0; | ||
| } |
There was a problem hiding this comment.
I wonder if we should target these classes to elements containing the class .alert, so that it doesn't interfere with users who may have their own fade transition with different settings?
Maybe:
.alert.fade-enter-active,
.alert.fade-leave-active {
transition: opacity .15s linear;
}
.alert.fade-enter,
.alert.fade-leave-to {
opacity: 0;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1512