New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): Add fade prop #1785

Merged
merged 2 commits into from Apr 29, 2018

Conversation

Projects
None yet
4 participants
@emanuelmutschlechner
Contributor

emanuelmutschlechner commented Apr 28, 2018

Closes #1512

@codecov

This comment has been minimized.

codecov bot commented Apr 28, 2018

Codecov Report

Merging #1785 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1785      +/-   ##
==========================================
+ Coverage   61.02%   61.04%   +0.01%     
==========================================
  Files         154      154              
  Lines        2861     2862       +1     
  Branches      790      791       +1     
==========================================
+ Hits         1746     1747       +1     
  Misses        800      800              
  Partials      315      315
Impacted Files Coverage Δ
src/components/alert/alert.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70e36d...ffe33a3. Read the comment docs.

@pi0

pi0 approved these changes Apr 29, 2018

Great! Would yu mind adding an example to the docs too?

@@ -16,10 +18,15 @@ export default {
[ this.$slots.dismiss ]
)
}
return h(
let alert = h(

This comment has been minimized.

@mosinve

mosinve Apr 29, 2018

Member

I'd use const here

@emanuelmutschlechner

This comment has been minimized.

Contributor

emanuelmutschlechner commented Apr 29, 2018

@pi0 Sure, let me know if this is ok.

@pi0

pi0 approved these changes Apr 29, 2018

@pi0 pi0 merged commit 0999b4c into bootstrap-vue:dev Apr 29, 2018

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-beta Your tests passed on CircleCI!
Details
ci/circleci: test-latest Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 61.02%)
Details
codecov/project 61.04% (+0.01%) compared to d70e36d
Details
deploy/netlify Deploy preview ready!
Details

@emanuelmutschlechner emanuelmutschlechner deleted the emanuelmutschlechner:feat-alert-fade branch Apr 29, 2018

@tmorehouse tmorehouse referenced this pull request Nov 14, 2018

Open

Bootstrap-Vue V2.x Tracker #2173

54 of 63 tasks complete
}
.fade-enter, .fade-leave-to {
opacity: 0;
}

This comment has been minimized.

@tmorehouse

tmorehouse Nov 21, 2018

Member

I wonder if we should target these classes to elements containing the class .alert, so that it doesn't interfere with users who may have their own fade transition with different settings?

Maybe:

.alert.fade-enter-active,
.alert.fade-leave-active {
     transition: opacity .15s linear;
 }
.alert.fade-enter,
.alert.fade-leave-to {
     opacity: 0;
 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment