New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): fix card and sub component render issues. Fixes #2062 #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`b-card-body` was not appearing in the component reference section of the docs
Codecov Report
@@ Coverage Diff @@
## dev #2125 +/- ##
==========================================
+ Coverage 64.81% 64.88% +0.06%
==========================================
Files 156 156
Lines 2950 2950
Branches 812 810 -2
==========================================
+ Hits 1912 1914 +2
+ Misses 751 749 -2
Partials 287 287
Continue to review full report at Codecov.
|
tmorehouse
changed the title
fix(card): fix card and subsomponent render issues. Fixes #2062
fix(card): fix card and sub component render issues. Fixes #2062
Nov 3, 2018
Placeholders help prevent complete re-renders of a component
This was referenced Nov 14, 2018
This was referenced Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
Fixes #2026
Spreads children/slots when pushing elements onto build stack
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:
PR titles should following the Conventional Commits naming convention