Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): fix card and sub component render issues. Fixes #2062 #2125

Merged
merged 14 commits into from Nov 3, 2018

Conversation

tmorehouse
Copy link
Member

Description of PR:

Fixes #2026

Spreads children/slots when pushing elements onto build stack


PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users?)

If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

PR titles should following the Conventional Commits naming convention

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #2125 into dev will increase coverage by 0.06%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2125      +/-   ##
==========================================
+ Coverage   64.81%   64.88%   +0.06%     
==========================================
  Files         156      156              
  Lines        2950     2950              
  Branches      812      810       -2     
==========================================
+ Hits         1912     1914       +2     
+ Misses        751      749       -2     
  Partials      287      287
Impacted Files Coverage Δ
src/components/card/card-header.js 100% <ø> (ø) ⬆️
src/components/card/card-footer.js 100% <ø> (ø) ⬆️
src/components/card/card-img.js 63.63% <ø> (ø) ⬆️
src/components/card/card-body.js 100% <100%> (ø) ⬆️
src/components/card/card.js 95.45% <93.33%> (+8.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8d0f0...faa35bd. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(card): fix card and subsomponent render issues. Fixes #2062 fix(card): fix card and sub component render issues. Fixes #2062 Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

b-form-input missing select() method
1 participant