feat(security): Strip HTML script tags before inserting content into DOM. Fixes #1974,#1665 #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utility for removing script tags from injected HTML (i.e. for use with v-html or domProps.innerHTML) Prevents user supplied input form injecting scripts into the DOM
Codecov Report
@@ Coverage Diff @@
## master #2129 +/- ##
=======================================
Coverage 60.83% 60.83%
=======================================
Files 154 155 +1
Lines 2885 2885
Branches 798 798
=======================================
Hits 1755 1755
Misses 812 812
Partials 318 318
Continue to review full report at Codecov.
|
Remove validator of size prop... to allow for custom CSS defined sizes
tmorehouse
changed the title
tmorehouse
changed the title
tmorehouse
added a commit
that referenced
this pull request
Nov 4, 2018
tmorehouse
added a commit
that referenced
this pull request
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
Utility for removing script tags from injected HTML (i.e. for use with
v-htmlordomProps.innerHTML)Prevents possible user supplied input form injecting scripts into the DOM
Fixes #1974
Fixes #1665
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
Scripts will no longer be injected into the DOM (i.e. from user supplied data or component props that support HTML)
The PR fulfills these requirements:
devbranch, not themasterbranchfixes #xxxx[,#xxxx], where "xxxx" is the issue number)If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:
PR titles should following the Conventional Commits naming convention