Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): Use custom CSS for no-caret option #1473 #2136

Merged
merged 2 commits into from Nov 4, 2018

Conversation

jacobmllr95
Copy link
Member

Description of PR:

This PR use custom CSS for the no-caret option on the <b-dropdown>component instead of removing the dropdown-toggle class from the toggle itself which can cause minor styling issues.

Closes #1473


PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fixes #xxxx[,#xxxx], where "xxxx" is the issue number)

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users?)

If adding a new feature, or changing the functionality of an existing feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

PR titles should following the Conventional Commits naming convention

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #2136 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2136   +/-   ##
=======================================
  Coverage   64.97%   64.97%           
=======================================
  Files         159      159           
  Lines        2958     2958           
  Branches      811      811           
=======================================
  Hits         1922     1922           
  Misses        749      749           
  Partials      287      287
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6f3f8...8e65964. Read the comment docs.

@tmorehouse tmorehouse merged commit 2eb706f into bootstrap-vue:dev Nov 4, 2018
@tmorehouse tmorehouse mentioned this pull request Nov 14, 2018
89 tasks
@jacobmllr95 jacobmllr95 deleted the fix-dropdown-no-caret branch November 14, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dropdown+nav-item-dropdown): noCaret option causes unwanted side effects
2 participants