Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add toggle method and root event (Closes #2708) #2709

merged 3 commits into from Feb 24, 2019


None yet
2 participants
Copy link

commented Feb 24, 2019

Description of Pull Request:

Adds a public method and root event to toggle a modal's visibility.

Closes #2708

To Do:

  • documentation udpate
  • component meta update

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)
feat(modal): add toggle method and root event
Adds a public method and root event to toggle a modal's visibility.

This comment has been minimized.

Copy link

commented Feb 24, 2019

Codecov Report

Merging #2709 into dev will decrease coverage by 0.15%.
The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff            @@
##            dev    #2709      +/-   ##
- Coverage    74%   73.85%   -0.16%     
  Files       173      173              
  Lines      3201     3209       +8     
  Branches    939      942       +3     
+ Hits       2369     2370       +1     
- Misses      610      614       +4     
- Partials    222      225       +3
Impacted Files Coverage Δ
src/components/modal/modal.js 55.11% <11.11%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e497b8...74cde14. Read the comment docs.

tmorehouse added some commits Feb 24, 2019

@tmorehouse tmorehouse requested a review from jackmu95 Feb 24, 2019

@tmorehouse tmorehouse removed the Status: WIP label Feb 24, 2019

@tmorehouse tmorehouse merged commit f67218e into dev Feb 24, 2019

7 of 9 checks passed

codecov/patch 11.11% of diff hit (target 74%)
codecov/project 73.85% (-0.16%) compared to 9e497b8
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
deploy/netlify Deploy preview ready!
security/snyk - package.json (pi0) No manifest changes detected

@tmorehouse tmorehouse deleted the tmorehouse/modal-toggle branch Feb 24, 2019

@tmorehouse tmorehouse referenced this pull request Feb 24, 2019


chore: release v2.0.0-rc.14 #2704

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.