Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add basic keyboard nav when table has row-clicked handler or is selctable (closes #2869) #2870

Merged
merged 19 commits into from Mar 19, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Mar 19, 2019

Description of Pull Request:

Add basic keyborad UP/DOWN (+SHIFT), HOME/END navigation when a table has a row-clicked handler or is selectable.

Closes #2869

To Do:

  • keyboard nav tests
  • documentation update (in accessibility section)

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2870 into dev will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2870      +/-   ##
==========================================
+ Coverage   86.79%   86.88%   +0.09%     
==========================================
  Files         197      197              
  Lines        3286     3310      +24     
  Branches      968      976       +8     
==========================================
+ Hits         2852     2876      +24     
  Misses        316      316              
  Partials      118      118
Impacted Files Coverage Δ
src/components/table/helpers/mixin-tbody-row.js 93.66% <100%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da49558...14da681. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review March 19, 2019 14:02
@tmorehouse tmorehouse merged commit ddcd66a into dev Mar 19, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/table-kbd branch March 24, 2019 13:46
@tmorehouse tmorehouse added this to Completed in 2.0.0 Stable Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2.0.0 Stable
  
Completed
Development

Successfully merging this pull request may close these issues.

Table row select arrow key support
2 participants