Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-modal): delay initially open modal via nextTick when using v-model or visible prop #3320

Merged
merged 5 commits into from May 18, 2019

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented May 17, 2019

Describe the PR

When modal is set to be initially open on mount, delay the show in a $nextTick() to help ensure DOM is fully loaded

Addresses #3312 (comment)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

…l or visible prop


When modal is set to be initially open on mount, delay the show in a `$nextTick()` to ensure DOM is fully loaded

Addresses #3312 (comment)
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #3320 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3320   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         218      218           
  Lines        4142     4142           
  Branches     1197     1197           
=======================================
  Hits         4110     4110           
  Misses         26       26           
  Partials        6        6
Impacted Files Coverage Δ
src/components/modal/modal.js 99.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b1cfd...d61be75. Read the comment docs.

@tmorehouse tmorehouse marked this pull request as ready for review May 17, 2019 14:34
@tmorehouse tmorehouse changed the title fix(modal): delay initially open modal via nextTick when using v-model or visible prop fix(b-modal): delay initially open modal via nextTick when using v-model or visible prop May 17, 2019
@jacobmllr95 jacobmllr95 merged commit 6f3010a into dev May 18, 2019
@jacobmllr95 jacobmllr95 deleted the tmorehouse/modal-delay branch May 18, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants