-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dropdown-item] Explicit component reference (fixes #360) #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need extends
?
@@ -17,6 +17,7 @@ | |||
|
|||
export default { | |||
extends: bLink, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need extends
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use a smarter refactoring approach by just extending and adding dropdown-item
class to bLink.
* upstream/master: (220 commits) [button-toolbar] docs (bootstrap-vue#368) ESLint New component b-button-toolbar (bootstrap-vue#367) [link] fix click event [docs] navbar styling Refactor link mixin [button-group] fix toolbar keynav (bootstrap-vue#366) [Docs] ScrollSpy directive JSFiddle [Link] Small fixes [link] Allow both router links and regular links to co-exist in same document (bootstrap-vue#365) [pagination] ARIA attributes + Keyboard navigation (bootstrap-vue#364) [dropdown-item] explicit component reference (bootstrap-vue#361) Additional ARIA on navs and dropdown (bootstrap-vue#358) ESLint [docs] ScrollSpy [scrollspy] SSR fix v0.15.6 [modal] focusFirst timing tweak (bootstrap-vue#357) [scrollspy] documentation update [scrollspy] Documentation (bootstrap-vue#356) ...
Addresses issue #360