Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-modal): ensure header is read for accessibility with JAWS (closes #3712) #3713

Merged
merged 3 commits into from Jul 19, 2019

Conversation

tmorehouse
Copy link
Member

Describe the PR

Move aria-labeledby and aria-describedby to role="dialog" div.

Closes #3712

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #3713 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3713   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         223      223           
  Lines        4377     4377           
  Branches     1235     1235           
=======================================
  Hits         4346     4346           
  Misses         25       25           
  Partials        6        6
Impacted Files Coverage Δ
src/components/modal/modal.js 99.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8104250...90a1adb. Read the comment docs.

@jacobmllr95 jacobmllr95 merged commit 6a9d0ce into dev Jul 19, 2019
@jacobmllr95 jacobmllr95 deleted the issue/3712 branch July 19, 2019 11:36
@tmorehouse
Copy link
Member Author

Oops.. there was one change I was going to make before merging... (comment on #3712), which would point the labelledby to the modal header header text (if present) instead of the header (which includes teh close button)

@tmorehouse tmorehouse restored the issue/3712 branch July 19, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<b-modal> header is not read for accessibility with JAWS
2 participants