[modal] allow Close button in Modal to be hidden #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorehouse
reviewed
May 11, 2017
lib/components/modal.vue
Outdated
| @@ -48,7 +48,7 @@ | |||
|
|
|||
| <footer class="modal-footer" ref="footer" v-if="!hideFooter"> | |||
| <slot name="modal-footer"> | |||
| <b-btn variant="secondary" @click="hide(false)">{{closeTitle}}</b-btn> | |||
| <b-btn variant="secondary" @click="hide(false) v-if="!hideClose">{{closeTitle}}</b-btn> | |||
There was a problem hiding this comment.
Missing a closing quote on @click="hide(false)
lib/components/modal.vue
Outdated
| @@ -161,6 +161,10 @@ | |||
| type: Boolean, | |||
| default: false | |||
| }, | |||
| hideClose: { | |||
There was a problem hiding this comment.
I wonder if this would be better called 'okOnly'?
Exactly. I'll make the 2 changes you've suggested. okOnly is probably better. |
|
Cool. I'll let @pi0 review. He should be back online in a few hours. |
|
Thanks! |
tmorehouse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.