-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tables] Allow slots for empty result sets #387
Conversation
Resync with Master
[modal] focusFirst timing tweak (#357)
Additional ARIA on navs and dropdown (#358)
Resync with master
[button-toolbar] docs (#368)
Better handling of modifiers A few code optimizations Removed excess usage comments
Resync with master
Make isActive a method. (#376)
tablist link role was inadvertently created as a bound attribute.
Resync with Master
It is not very clear in the documentation that the I'll be happy to update the documentation to make this clearer for others, but just want to double-check this is the intended behaviour. |
I think documentation is fine. |
Is it too much hard work to add a few words to the row in the table under the "Slots" heading to make developers aware the I will be happy to do this myself and submit a pull request, but I stand by what I said - it is not clear and good documentation should be clear about technical behaviour. It is only after using the component and wasting time tracking down why the slot wasn't working that I now know why this happens: it's because I can see there is a default message that gets displayed which the |
+1 for @bastones comment on adding info to the documentation. It doesn't make it clear |
added two slots:
empty
to be shown if no items (items.length === 0
)emptyFiltered
to be shown if a filtered result (_items.length === 0
) has no recordsand one prop
showEmpty
to enable showing the empty slotsOne method to address issue #385
There might be better ways to do this though. comments/changes welcome.