Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all non-major dependencies #4033

Merged
merged 16 commits into from Sep 9, 2019
Merged
16 changes: 11 additions & 5 deletions docs/nuxt.config.js
Expand Up @@ -179,11 +179,17 @@ module.exports = {
height: '3px'
},

manifest: {
name: 'BootstrapVue',
short_name: 'BootstrapVue',
description: 'Quickly integrate Bootstrap v4 components with Vue.js',
theme_color: '#563d7c'
pwa: {
icon: {
// iconFileName: 'icon.png',
iconSrc: '~/static/icon.png'
},
manifest: {
name: 'BootstrapVue',
short_name: 'BootstrapVue',
description: 'Quickly integrate Bootstrap v4 components with Vue.js',
theme_color: '#563d7c'
}
},

generate: {
Expand Down
20 changes: 10 additions & 10 deletions package.json
Expand Up @@ -78,14 +78,14 @@
"vue-functional-data-merge": "^3.1.0"
},
"devDependencies": {
"@babel/cli": "^7.5.5",
"@babel/core": "^7.5.5",
"@babel/plugin-transform-modules-commonjs": "^7.5.0",
"@babel/plugin-transform-runtime": "^7.5.5",
"@babel/preset-env": "^7.5.5",
"@babel/standalone": "^7.5.5",
"@babel/cli": "^7.6.0",
"@babel/core": "^7.6.0",
"@babel/plugin-transform-modules-commonjs": "^7.6.0",
"@babel/plugin-transform-runtime": "^7.6.0",
"@babel/preset-env": "^7.6.0",
"@babel/standalone": "^7.6.0",
"@nuxtjs/google-analytics": "^2.2.0",
"@nuxtjs/pwa": "^3.0.0-beta.16",
"@nuxtjs/pwa": "^3.0.0-beta.17",
"@vue/test-utils": "^1.0.0-beta.29",
"autoprefixer": "^9.6.1",
"babel-core": "^7.0.0-bridge.0",
Expand Down Expand Up @@ -123,15 +123,15 @@
"nuxt": "^2.9.2",
"postcss-cli": "^6.1.3",
"prettier": "1.14.3",
"rollup": "^1.20.3",
"rollup": "^1.21.0",
"rollup-plugin-babel": "^4.3.3",
"rollup-plugin-commonjs": "^10.1.0",
"rollup-plugin-node-resolve": "^5.2.0",
"sass-loader": "^8.0.0",
"standard-version": "^7.0.0",
"terser": "^4.2.1",
"terser": "^4.3.0",
"vue": "^2.6.10",
"vue-jest": "^3.0.4",
"vue-jest": "^3.0.5",
"vue-router": "^3.1.3",
"vue-server-renderer": "^2.6.10",
"vue-template-compiler": "^2.6.10"
Expand Down
7 changes: 4 additions & 3 deletions src/components/modal/helpers/bv-modal.js
Expand Up @@ -79,10 +79,11 @@ const plugin = Vue => {
// Self destruct after hidden
this.$once('hidden', handleDestroy)
// Self destruct on route change
/* istanbul ignore next */
/* istanbul ignore if */
if (this.$router && this.$route) {
const unwatch = this.$watch('$router', handleDestroy)
this.$once('hook:beforeDestroy', unwatch)
// Destroy ourselves if route changes
/* istanbul ignore next */
this.$once('hook:beforeDestroy', this.$watch('$router', handleDestroy))
}
// Show the `BMsgBox`
this.show()
Expand Down
1 change: 1 addition & 0 deletions src/components/modal/modal.js
Expand Up @@ -453,6 +453,7 @@ export const BModal = /*#__PURE__*/ Vue.extend({
/* istanbul ignore next */
return
}
/* istanbul ignore next */
if (this.isClosing) {
// If we are in the process of closing, wait until hidden before re-opening
/* istanbul ignore next */
Expand Down
3 changes: 1 addition & 2 deletions src/components/pagination-nav/pagination-nav.js
Expand Up @@ -25,9 +25,8 @@ const props = {
numberOfPages: {
type: [Number, String],
default: 1,
validator(value) {
validator(value) /* istanbul ignore next */ {
const num = parseInt(value, 10)
/* istanbul ignore next */
if (isNaN(num) || num < 1) {
warn('b-pagination: prop "number-of-pages" must be a number greater than 0')
return false
Expand Down
22 changes: 12 additions & 10 deletions src/components/table/helpers/mixin-provider.js
Expand Up @@ -153,16 +153,18 @@ export default {
} else if (isArray(data)) {
// Provider returned Array data
this._providerSetLocal(data)
} else if (this.items.length !== 2) {
// Check number of arguments provider function requested
// Provider not using callback (didn't request second argument), so we clear
// busy state as most likely there was an error in the provider function
/* istanbul ignore next */
warn(
"b-table provider function didn't request callback and did not return a promise or data"
)
/* istanbul ignore next */
this.localBusy = false
} else {
/* istanbul ignore if */
if (this.items.length !== 2) {
// Check number of arguments provider function requested
// Provider not using callback (didn't request second argument), so we clear
// busy state as most likely there was an error in the provider function
/* istanbul ignore next */
warn(
"b-table provider function didn't request callback and did not return a promise or data"
)
this.localBusy = false
}
}
} catch (e) /* istanbul ignore next */ {
// Provider function borked on us, so we spew out a warning
Expand Down
1 change: 1 addition & 0 deletions src/components/toast/toast.js
Expand Up @@ -203,6 +203,7 @@ export const BToast = /*#__PURE__*/ Vue.extend({
// Make sure we hide when toaster is destroyed
/* istanbul ignore next: difficult to test */
this.listenOnRoot('bv::toaster::destroyed', toaster => {
/* istanbul ignore next */
if (toaster === this.computedToaster) {
/* istanbul ignore next */
this.hide()
Expand Down
1 change: 1 addition & 0 deletions src/components/tooltip/helpers/bv-tooltip.js
Expand Up @@ -407,6 +407,7 @@ export const BVTooltip = /*#__PURE__*/ Vue.extend({
/* istanbul ignore next: ignore for now */
if (hideEvt.defaultPrevented) {
// Don't hide if event cancelled
/* istanbul ignore next */
return
}

Expand Down
6 changes: 2 additions & 4 deletions src/mixins/pagination.js
Expand Up @@ -53,9 +53,8 @@ export const props = {
value: {
type: [Number, String],
default: null,
validator(value) {
validator(value) /* istanbul ignore next */ {
const num = parseInt(value, 10)
/* istanbul ignore next */
if (!isNull(value) && (isNaN(num) || num < 1)) {
warn('pagination: v-model value must be a number greater than 0')
return false
Expand All @@ -66,9 +65,8 @@ export const props = {
limit: {
type: [Number, String],
default: DEFAULT_LIMIT,
validator(value) {
validator(value) /* istanbul ignore next */ {
const num = parseInt(value, 10)
/* istanbul ignore next */
if (isNaN(num) || num < 1) {
warn('pagination: prop "limit" must be a number greater than 0')
return false
Expand Down