New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-dropdown): handle issue with touch devices on MacOS using Safari/Firefox (Fixes #4328, #4344) #4329
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4329 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 238 238
Lines 4585 4592 +7
Branches 1286 1287 +1
==========================================
+ Hits 4581 4588 +7
Misses 3 3
Partials 1 1
Continue to review full report at Codecov.
|
Awaiting on feedback from issue #4328 |
@tmorehouse Tested it in Safari on iOS and it doesn't solve the issue. Will look into it soon. |
@jackmu95 I wonder if this s a timing thing (or order of events) issue... maybe related to the click outside handler closing the menu, and then the subsequent button click re-opening the menu (i.e. clickout happens first, then button click happens after) |
Hmmm I just checked, and the clickout (focusout) handler tests for focus moving to the toggler (and ignores it)... so I don't think it is a race condition between the toggle handler and the focusOut handler. |
The problem was that we listened for the I've moved the close detection back to a document-wide @achen116 Can you confirm that the new deploy preview works for you? |
@jackmu95 still need to wait for the deploy-preview to build... for some reason it didn't get triggered |
@achen116, can you try out the deploy preview again now? https://deploy-preview-4329--bootstrap-vue.netlify.com/ |
Describe the PR
Fixes #4328
Fixes #4344
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: