New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] components - show if prop is required #442
Conversation
Should address issue #396
Coerce slide nodelist into an Array
Resync with master
Resync with master
Resync with master
Resync with master
Resync with master
Added an extra column to props table to show if property is marged as required Shows `true` is required, otherwise blank (to not clutter table output)
Option: Could show the word 'Yes' instead of What do you guys think? |
Hmm... either is clear, but I think I lean towards "Yes". |
And should we show 'No' if not required or just a blank? |
I like the no clutter approach, but I suppose having the table column empty would look silly. It would be ideal if the column only appears if there is a required prop (then it would show Yes/No). |
There is the Could get the fields to check if there are any |
That sounds like cleanest, easiest to understand way. |
Adds invisible state to required column if no props are required
Also switched from word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Wait, is that... never mind! You just changed it! |
I'm gonna say you caught that before committing an official Troy-o |
LOL |
Hmmm. Now I am wondering if it might be better to just remove the |
Only adds the `Required` column to properties if there are any props with required set.
The |
Some components have props that are flagged as required.
This PR adds an extra column to props table to show if property is marked as required
Shows
true
is required, otherwise blank (to not clutter table output)