Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tooltip] fix for #435 #450

Merged
merged 11 commits into from May 24, 2017
Merged

[tooltip] fix for #435 #450

merged 11 commits into from May 24, 2017

Conversation

tmorehouse
Copy link
Member

Remove !important from display: block; css

Fixes #435

@tmorehouse
[carousel] Fixed this arg in forEach
74b15d4 
Should address issue #396
@tmorehouse
[carousel] coerce querySelectorAll into an array
8a961f5 
Coerce slide nodelist into an Array
@tmorehouse
[carousel] ESLint
5e6a5ba
@tmorehouse
Merge pull request #1 from bootstrap-vue/master
244800c 
Resync with master
@tmorehouse
Merge pull request #2 from bootstrap-vue/master
656a8e2 
Resync with master
@tmorehouse
Merge pull request #3 from bootstrap-vue/master
2830201 
Resync with master
@tmorehouse
Merge pull request #4 from bootstrap-vue/master
a2de129 
Resync with master
@tmorehouse
Merge pull request #5 from bootstrap-vue/master
c7daa0a 
Resync
@tmorehouse
Merge pull request #6 from bootstrap-vue/master
48ac553 
Resync with master
@tmorehouse
Merge pull request #7 from bootstrap-vue/master
916bbe0 
Resync with master
@tmorehouse
[tooltip] fix issue #435
54c748b 
Remove `!important` from `display: block;` css

Fixes #435
@tmorehouse tmorehouse requested review from pi0 and GregPeden May 24, 2017 00:31
@tmorehouse
Copy link
Member Author

tmorehouse commented May 24, 2017 •
edited

It appears the !important was allowing the hidden (opacity: 0) tooltip element to "cover" focusable elements, preventing them from being clicked in some instances (as described in issue #435)

@pi0 pi0 merged commit 2889495 into bootstrap-vue:master May 24, 2017
@CryptoZ258
Copy link

OK, good job

@tmorehouse tmorehouse deleted the tmorehouse-tooltip branch May 24, 2017 14:28
@tmorehouse tmorehouse mentioned this pull request Jun 8, 2017
Closed
@tmorehouse tmorehouse added this to the v0.17.0 milestone Jun 17, 2017
@tmorehouse tmorehouse mentioned this pull request Jun 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

@GregPeden GregPeden Awaiting requested review from GregPeden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmorehouse @CryptoZ258 @pi0