Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-form-radio-group) make sure to pass state to form radio options for contextual feedback (closes #6357) #6366

Merged

Conversation

TomSmith27
Copy link
Contributor

@TomSmith27 TomSmith27 commented Jan 27, 2021

Describe the PR

Make sure to pass state prop to form radio options for contextual feedback.

Closes #6357.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented Jan 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/i1oeoohr8
✅ Preview: https://bootstrap-vue-git-fork-tomsmith27-fix-form-radio-valida-86ace1.bootstrap-vue.vercel.app

@TomSmith27 TomSmith27 changed the title fix(b-form-radio-group) make sure to pass state to form radio options for contextual feedback (fixes #6357) fix(b-form-radio-group) make sure to pass state to form radio options for contextual feedback (closes #6357) Jan 27, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e97e24d:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #6366 (e97e24d) into dev (1e6b369) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6366   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          299       299           
  Lines        10105     10105           
  Branches      2510      2510           
=========================================
  Hits         10105     10105           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mixins/form-radio-check-group.js 100.00% <ø> (ø)
src/components/form-radio/form-radio.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6b369...e97e24d. Read the comment docs.

@jacobmllr95 jacobmllr95 self-requested a review January 27, 2021 12:40
@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix labels Jan 27, 2021
@jacobmllr95 jacobmllr95 added this to In progress in v2.22.0 via automation Jan 27, 2021
@jacobmllr95
Copy link
Member

@TomSmith27 Thanks for the initial investigation but your fix wasn't the root cause of the issue.
<b-form-checkbox> and <b-form-radio> use the shared formRadioCheckMixin mixin with grabs some information from the group, when available.

The problem with <b-form-radio> was that it re-applied the formStateMixin which caused the adapted computedState computed property from the formRadioCheckMixin mixin to be overwritten.

@jacobmllr95 jacobmllr95 merged commit 5d64a65 into bootstrap-vue:dev Jan 27, 2021
v2.22.0 automation moved this from In progress to Done Jan 27, 2021
@TomSmith27
Copy link
Contributor Author

Ah ok thanks @jackmu95 that's good to know! I have been following the Vue3 chat in the other issue and thought I would start trying to contribute I will see if they are any more issues i can pick up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
v2.22.0
  
Done
Development

Successfully merging this pull request may close these issues.

Form radio contextual state not applied correctly
2 participants