-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-form-radio-group) make sure to pass state to form radio options for contextual feedback (closes #6357) #6366
fix(b-form-radio-group) make sure to pass state to form radio options for contextual feedback (closes #6357) #6366
Conversation
… for contextual feedback
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/i1oeoohr8 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e97e24d:
|
Codecov Report
@@ Coverage Diff @@
## dev #6366 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10105 10105
Branches 2510 2510
=========================================
Hits 10105 10105
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@TomSmith27 Thanks for the initial investigation but your fix wasn't the root cause of the issue. The problem with |
Ah ok thanks @jackmu95 that's good to know! I have been following the Vue3 chat in the other issue and thought I would start trying to contribute I will see if they are any more issues i can pick up |
Describe the PR
Make sure to pass
state
prop to form radio options for contextual feedback.Closes #6357.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: