Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-table): default role to grid when selectable and table otherwise #6383

Merged
merged 11 commits into from
Jan 31, 2021
Merged

fix(b-table): default role to grid when selectable and table otherwise #6383

merged 11 commits into from
Jan 31, 2021

Conversation

andrei-gheorghiu
Copy link
Contributor

Describe the PR

Resulting <table> of <b-v-table> should have a default role of table.
If selectable is true, the role applied should be grid.

In both cases, user-provided role has priority.

Related: #6305

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented Jan 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/bxhpqivan
✅ Preview: https://bootstrap-vue-git-fork-andrei-gheorghiu-ag-table-role.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 31, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83cf46c:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #6383 (344029a) into dev (9e25a3b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          299       299           
  Lines        10141     10142    +1     
  Branches      2524      2522    -2     
=========================================
+ Hits         10141     10142    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/table/helpers/mixin-selectable.js 100.00% <100.00%> (ø)
...c/components/table/helpers/mixin-table-renderer.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e25a3b...83cf46c. Read the comment docs.

@andrei-gheorghiu andrei-gheorghiu changed the title fix(b-v-table): default table role to grid when selectable and table otherwise fix(b-table): default table role to grid when selectable and table otherwise Jan 31, 2021
@jacobmllr95 jacobmllr95 changed the title fix(b-table): default table role to grid when selectable and table otherwise fix(b-table): default table role to grid when selectable and table otherwise Jan 31, 2021
@jacobmllr95 jacobmllr95 self-requested a review January 31, 2021 23:04
@jacobmllr95 jacobmllr95 added this to In progress in v2.22.0 via automation Jan 31, 2021
@jacobmllr95 jacobmllr95 changed the title fix(b-table): default table role to grid when selectable and table otherwise fix(b-table): default role to grid when selectable and table otherwise Jan 31, 2021
@jacobmllr95 jacobmllr95 merged commit 3f5a309 into bootstrap-vue:dev Jan 31, 2021
v2.22.0 automation moved this from In progress to Done Jan 31, 2021
@jacobmllr95
Copy link
Member

Thanks @andrei-gheorghiu!

@andrei-gheorghiu andrei-gheorghiu deleted the ag/table-role branch January 31, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2.22.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants