-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: replace sass division with multiplication (fixes #6830) #6834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/8qZah4whKnQ14td95miJSvR5QQt7 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1510721:
|
@jacobmllr95 Please take a look |
I triumphantly updated my bootstrap version to v4.6.1 before realizing bootstrap-vue had sass division too. Came here to make a PR but @z1m1n beat me too it! Thank you 👏🏻 |
Can we please merge this PR? |
get this merged asap please ;) |
Bump |
I'm going to merge this today :) Just need to filter-out extra white-space changes :) |
Codecov Report
@@ Coverage Diff @@
## dev #6834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10263 10263
Branches 2523 2523
=========================================
Hits 10263 10263
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@z1m1n thank you for your contribution! I'm happy to merge it 🚀 |
Describe the PR
Replace Sass division with multiplication (required for sass versions greater than 1.32.13) (fixes #6830)
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed: