New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-radio): Support button style radios #728

Merged
merged 13 commits into from Jul 25, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 23, 2017

Adds new Boolean prop buttons (defaults to false) that wil enable the radios to be rendered with the look of buttons.
http://v4-alpha.getbootstrap.com/components/buttons/#checkbox-and-radio-buttons

Currently the buttons can only be rendered with the same variant specified by the prop button-variant. Different variants for each radio button ar currently not supported (not without altering the form-options.js mixin).

stacked button radios are supported,, but state is not supported for button radios

tmorehouse added some commits Jul 23, 2017

feat(form-radio): Support button style radios
Adds new Boolean prop `buttons` (defaults to `false`) that wil enable the radios to be rendered with the look of buttons
http://v4-alpha.getbootstrap.com/components/buttons/#checkbox-and-radio-buttons

Currently the buttons can only be rendered with the same variant specified by the prop `button-variant`.  Different variants for each radio button ar currently not supported (not without altering the `form-options.js` mixin.

`stacked` button radios are supported,, but `state` is not supported for button radios

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 23, 2017

@tmorehouse tmorehouse requested review from alexsasharegan, mosinve and pi0 Jul 23, 2017

tmorehouse and others added some commits Jul 23, 2017

[form-radio] Apply focus class to label, not input
Only apply 'focus' class on label element
@@ -50,7 +50,7 @@ Please see options in [`<b-form-select>`](./form-select) docs for details on pas
options (value array) to `<b-form-radio>`
### Size
Constrol the size of the radio text by setting the prop `size` to either `sm` for small or
Control the size of the radio text by setting the prop `size` to either `sm` for small or

This comment has been minimized.

@tmorehouse
@mosinve

All good, only one offer - if it's possible, to add live example of button-looking radios in addiction to html code example.,

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 25, 2017

Example was missing a comma, so not it is working.

@tmorehouse tmorehouse merged commit c7c150f into master Jul 25, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-radio-buttons branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment