More Vue2 style + bugfixes #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
pushed a commit
that referenced
this pull request
Apr 21, 2017
* dropdown item Keyboard navigation for ARIA More closely aligns with proposed Bootstrap V4 dropdown keyboard navigation. (similar to how native select elements work) When dropdown opens, the dropdown menu is focused. Keyboard up/down will navigate the dropdown list. tabbing out of the dropdown will close the dropdown (and focus the next element based on normal tab flow). hitting ESC will also close the dropdown and refocus either the button or toggle button (depending on if the button is split or not). Also made the .sr-only "Toggle Dropdown" text a prop (toggleText) to allow for different languages. * Changed tabs to spaces * Changed tabs to spaces * fixed typo on toggleText prop * Typo * Better ES6 syntax * Update dropdown.vue * Revert for now * Fixed feedback class, & change choosing target ID Changed feedback text block from class 'form-text' to 'form-control-feedback' to convey state. Added ARIA role="alert" to feedback div. Changed the target select from first child of content to querySelector() of first input element in content ref. * Fixed form-option disabled bug Option `disabled` wasn't being factored into `formOptions()` computed result. * Fixed form-option disabled bug Option disabled wasn't being factored into formOptions() Return disabled = false if "falsey" * Merging latest master commits (#6) * Fix validation on 'offset' prop in Popover * Add 'targetOffset' prop to Popover * Fix lint tests - comment edit just included to permit commit * Latest from master fork (#7) * Fix validation on 'offset' prop in Popover * Add 'targetOffset' prop to Popover * Fix lint tests - comment edit just included to permit commit * Revert "Latest from master fork (#7)" (#8) This reverts commit 3222513.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All components that changes local property directly should be fixed... It is anti pattern of Vue2.
For now i fixed only alert.vue. More updates coming soon.