Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card): add card-body functional component & card-img fixes #843

Merged
merged 18 commits into from Aug 15, 2017
Merged

feat(card): add card-body functional component & card-img fixes #843

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4eb67ba
feat(card-img): add img-fluid class and img-bottom ability
Aug 14, 2017
1b79ac0
fix(card-img): reduce repetitive code
Aug 14, 2017
2b9e460
fix(card): keep img from rendering when no img
Aug 14, 2017
5a20964
refactor(card): remove difficult ternaries
Aug 14, 2017
d0e8079
feat(card): add body tag, remove img slot
Aug 14, 2017
64b6fd1
feat(card-body): add card-body FC
Aug 14, 2017
19dc945
fix: add card-body to lib export and fix some docs
Aug 14, 2017
8424b3d
[meta.json] removed unused slot names
tmorehouse Aug 14, 2017
99ae683
Merge branch '1.x' into fix/card-img
tmorehouse Aug 14, 2017
1c565dc
fix(card): update to bg-variant & border-variant
Aug 15, 2017
2cbe3b8
fix(card): doc fixes for new props
Aug 15, 2017
ddb94b8
chore(docs): better markup formatting
Aug 15, 2017
762f293
fix(docs): bad syntax + better formatting
Aug 15, 2017
d5466e4
fix(docs): card doc fmt
Aug 15, 2017
889f537
fix(docs): more fmt
Aug 15, 2017
a8d8737
fix(docs): blockquote ex on card
Aug 15, 2017
55b4130
Card-body custom class assignment test
mosinve Aug 15, 2017
94c2dcb
fix(test): use helpers and ref on card test
Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/components/card.spec.js
View file
Open in desktop
Expand Up @@ -118,9 +118,8 @@ describe("card", async () => {
expect($refs.card_group).toBeElement("section");
});

it('CardBody should have assigned class', async () => {
const {app: {$refs}} = window;
const body = $refs.card_body.children[0];
expect(body.classList.contains('card-text')).toBe(true);
it("CardBody should have assigned class", async () => {
const { app: { $refs } } = window;
expect($refs.body).toHaveClass("card-text");
Copy link
Member

@mosinve mosinve Aug 15, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, didnt know that it can be used that way )) 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and it works across FC's and VM's! When I started with FC's, I knew testing helpers needed to be simpler to use against either.

});
});