objc_message_field.cc and objc_enum_field.cc generate code that leaks copied objects

[macdrevx]

On line 365 of objc_message_field.cc and on line 343 of objc_enum_field.cc, the copied object is assigned to a retain property. The copied objects, should therefore be autoreleased.

This issue was flagged in generated code in another project by the Xcode 4.1 static analyzer.

[jparise]

Thanks for spotting that! -autorelease is fine here, but we could also assign the array copy to a local variable and -release it immediately after using it to set the property.

[macdrevx]

Yes, that is probably a better way to go.

Will you be updating the project to use automatic reference counting at some point? I noticed that one person has made a first pass at doing so in another fork of the project.

Andrew Hershberger

On Thursday, August 25, 2011 at 3:27 PM, jparise wrote:

Thanks for spotting that! -autorelease is fine here, but we could also assign the array copy to a local variable and -release it immediately after using it to set the property.

Reply to this email directly or view it on GitHub:
#4 (comment)

[jparise]

I don't have any plans to do anything with ARC at the moment, but I'm open to patches.