Fix svgbob diagrams in dark mode #28
Conversation
|
When I downloaded it, I got and the test failure is with I guess this is because of the |
|
Yes, that seems to be the issue. |
I would suggest making a separate PR that updates the |
| @@ -16,5 +16,5 @@ pub fn bob_handler(s: &str, settings: &Settings) -> String { | |||
| svg.render_with_indent(&mut source, 0, true).expect("html render"); | |||
|
|
|||
| let style = Style::new("svg { width: 100% !important; }").set("type", "text/css"); | |||
| format!("<div style='width:100%; height:{}px;'>{}{}</div>", height, style, source).replace('\n', "") | |||
| format!("<div style='width:100%; height:{}px; fill:var(--fg);'>{}{}</div>", height, style, source).replace('\n', "") | |||
There was a problem hiding this comment.
I just noticed that there is a number of configuration options — could it be that we just need to update the default for fill_color?
There was a problem hiding this comment.
Updating the default for fill_color does not work for some reason.
There was a problem hiding this comment.
Okay, thanks for checking! Then I just think you need to rebase this PR on top of master and that will make the tests pass.
There was a problem hiding this comment.
@boozook, do you know more about or are you fine with just adding the CSS here?
Closes #22
Currently, the SVG text elements receive the default color, black, which is not readable on dark mode.
This PR adds a one-liner CSS fix to apply the foreground css variable (var(--fg)) to the svg text element to make svg text legible and visible.