New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import error after pyinstaller #133
Comments
You have to add an hidden import for PyInstaller when you use the current master code:
|
What's the best practices around pyinstaller? Should |
I don't know what is the best practice with pyinstaller. The problem is the use of importlib and the fact that it effectively hides the import from pyinstaller: Lines 120 to 127 in 14cd6f5
The previous if-else-import chain was fully compatible with pyinstaller: Is there any reason why we can't go back to this? |
Ah, so PyInstaller is probably parsing the source code to find imports. No, there's no reason why we cannot go back. I'll revert the change as soon as I get home. Now I feel kinda stupid for doing that just to get 100% coverage. Oh well, living is learning. |
Hi,
The same without IPython. Regards, |
Hello, C:\Users\brand\Desktop\VirusShooter>"Virus Shooter.py" |
I install keyboard from master code.
The text was updated successfully, but these errors were encountered: