Fix some non-steam shortcuts being skipped #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex expression parsing shortcuts.vfd file has been modified so it doesn't skip shortcuts where 4-byte appid is translated into less-than-4 character UTF-8 text. Before fix: appid had to be matched to exactly 4 characters. But regexp matches UTF-8 so sometimes it could be 1,2 or 3 characters. After fix: appid is matched to an UTF-8 text of 1 to 4 characters. Matched byte length of appid is always 4.
|
Looks good, thanks for the contribution! |
|
(by the way, this was not automated, I just happened to catch your PR quickly and understand the regex expression well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex expression parsing shortcuts.vfd file has been modified so it doesn't skip shortcuts where 4-byte appid is translated into less-than-4 character UTF-8 text.
Before fix: appid had to be matched to exactly 4 characters. But regexp matches UTF-8 so sometimes it could be 1,2 or 3 characters.
After fix: appid is matched to an UTF-8 text of 1 to 4 characters. Matched byte length of appid is always 4.
Fixes #110.