Complete GtkDialog, GtkGrid, and XML UI for settings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yihuajack
commented
Mar 10, 2022
yihuajack
commented
- Use XML UI for settings window in terms of GtkBuilder
- Use GtkDialog instead of GtkWindow (however, content_area only)
- Use GtkGrid instead of GtkBox (vbox, etc.)
- Add Glade file for reference
- Modify Git ignore settings
- Update README
Make it runnable
Use GtkDialog instead of GtkWindow; use XML UI for settings; update README; fix transient issue of GtkDialog; use GtkGrid instead of GtkBox (vbox, etc.); add Glade file for reference; use suitable Git ignore settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.