This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Changes for Windows compatibility #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngosang
force-pushed
the
feature/windows_supp
branch
from
e405c31
to
526a726
Compare
|
@boramalper I rebased this PR. Without this change magenetico couldn't stablish outgoing connections in Windows. |
|
I'm not a Windows expert, but maybe you want to try my asyncio branch on Windows. The asyncio module is supposed to abstract away many of the OS idiosyncrasies. #76 |
|
Closing the PR since we moved from Python 3 to Go. =) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.