Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Customize binary location #41

Open
axelson opened this issue Jan 10, 2021 · 1 comment
Open

Feature request: Customize binary location #41

axelson opened this issue Jan 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@axelson
Copy link

axelson commented Jan 10, 2021

Hi, first off, thanks for this software, it's great and very fast! :)

I'd like to make a request to use a non-default binary location on the remarkable tablet. Currently for the RM2 the binary path appears to be hardcoded to /home/root/rM-vnc-server-standalone. I'd like to customize that to /home/root/bin/rM-vnc-server-standalone as part of an effort to keep my /home/root directory clean and uncluttered.

I see two main options for this:

  1. Add a binary_path option to the host computer's ~/.config/rmview.json file
  2. Add /home/root/bin/rM-vnc-server-standalone as a path for rmview to look for the binary, and use it if found

If either of those approaches (or a third one) appeals to you, then I could look into preparing a PR.

@bordaigorl
Copy link
Owner

Hi! This is definitely something I wanted to add at some point.
I think option 1 is the best. I would go with something like a vnc_server_path key for the setting.
This is because if in the future we want to call more than just one binary we don't have ambiguous setting keys.
If you could prepare a PR I'd be happy to review and merge!

@bordaigorl bordaigorl added the enhancement New feature or request label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants