Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for webclips and new codeblocks #210

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Commits on Oct 12, 2018

  1. Fixing parsing of Evernote's new codeblocks, by reverse engineering

    They could have used `<pre>`, they could have introduced an `<en-codeblock>` element.
    But no. They choose a custom CSS style `-en-codeblock:true`.
    
    This is obviously fragile.
    bordaigorl committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    a607378 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1144e58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    530f706 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Fixing webclip divs

    Two problems:
    
    1. distinguishing styled divs that are made by user (so may contain markdown) and the ones produced by webclips which need to be copied verbatim
    2. avoid fooling markdown2 which does not tag matching to find boundaries of HTML so it gets confused with nested divs
    
    Problem 1 is solved by looking for the `-evernote-webclip` style (not documented)
    Problem 2 is solved by using verbatim output for webclip contents, and prepending a space to each line so that nested `</div>` are ignored.
    bordaigorl committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    4a9e725 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Configuration menu
    Copy the full SHA
    8aaca53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a8f6ce View commit details
    Browse the repository at this point in the history