Specify a locale of en_US_POSIX to avoid localization problems in certain situations #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tain situations, documented by Apple at https://developer.apple.com/library/ios/qa/qa1480/_index.html . This was seen in testing with iOS, when using a British English current locale and choosing a 12-hour date preference in Settings. NSDateFormatter actually rewrote the format to output "hh a" despite the request to print out "HH". Using the POSIX locale ensures the output is not subject to user preferences, which is desired when printint out an ISO6801 compliant format.
|
The merge commit: 738a614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify a locale of en_US_POSIX to avoid localization problems in certain situations, documented by Apple at https://developer.apple.com/library/ios/qa/qa1480/_index.html . This was seen in testing with iOS, when using a British English current locale and choosing a 12-hour date preference in Settings. NSDateFormatter actually rewrote the format to output "hh a" despite the request to print out "HH". Using the POSIX locale ensures the output is not subject to user preferences, which is desired when printint out an ISO6801 compliant format.
Whoops, I didn't see the existing pull request. If they managed to get a unit test, that is better, but I think it is missing another place where the locale could be specified.